reduce memory usage of Scope.t #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatchi
force-pushed
the
reduce-mem-usage-scope
branch
from
09ca2dd to
c94c074
Compare
tatchi
commented
Oct 10, 2024
| @@ -845,15 +919,19 @@ module Scope = struct | |||
| call it if there is an instrumentation backend. *) | |||
| let[@inline] add_attrs (scope : t) (attrs : unit -> key_value list) : unit = | |||
| if Collector.has_backend () then | |||
| scope.attrs <- List.rev_append (attrs ()) scope.attrs | |||
| scope.items <- | |||
| List.fold_left (fun acc attr -> Attr (attr, acc)) scope.items (attrs ()) | |||
There was a problem hiding this comment.
I didn't think about the order; does it matter ?
There was a problem hiding this comment.
I don't think it should matter, no :)
tatchi
force-pushed
the
reduce-mem-usage-scope
branch
from
c94c074 to
ac1a27e
Compare
c-cube
approved these changes
Oct 11, 2024
| @@ -845,15 +919,19 @@ module Scope = struct | |||
| call it if there is an instrumentation backend. *) | |||
| let[@inline] add_attrs (scope : t) (attrs : unit -> key_value list) : unit = | |||
| if Collector.has_backend () then | |||
| scope.attrs <- List.rev_append (attrs ()) scope.attrs | |||
| scope.items <- | |||
| List.fold_left (fun acc attr -> Attr (attr, acc)) scope.items (attrs ()) | |||
There was a problem hiding this comment.
I don't think it should matter, no :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my take at implementing your suggestion to reduce
Scope.tmemory usage